Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129593002: Add Galaxy S4 and Nexus 4 to platform AEC whitelist. (Closed)

Created:
6 years, 11 months ago by ajm
Modified:
6 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add Galaxy S4 and Nexus 4 to platform AEC whitelist. TESTED=Good quality AEC using apprtc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ajm
Should be a less controversial change ;)
6 years, 11 months ago (2014-01-08 22:19:41 UTC) #1
henrika (OOO until Aug 14)
LGTM ;-)
6 years, 11 months ago (2014-01-09 09:20:06 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 11 months ago (2014-01-09 16:01:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/129593002/1
6 years, 11 months ago (2014-01-09 21:07:07 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44156
6 years, 11 months ago (2014-01-09 21:51:13 UTC) #5
ajm
Ah, didn't realize you weren't owners. Ami, could you owner-stamp this?
6 years, 11 months ago (2014-01-09 22:56:20 UTC) #6
Ami GONE FROM CHROMIUM
LGTM
6 years, 11 months ago (2014-01-09 23:30:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/129593002/1
6 years, 11 months ago (2014-01-10 00:08:26 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244567
6 years, 11 months ago (2014-01-10 05:20:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/129593002/1
6 years, 11 months ago (2014-01-10 06:13:30 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 07:26:15 UTC) #11
Message was sent while issue was closed. 
Change committed as 244117

Powered by Google App Engine
This is Rietveld 408576698