Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295903005: [DevTools] Implementation of resource requests blocked by specific urls. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, Yoav Weiss, kinuko+watch, pfeldman+blink_chromium.org, gavinp+loader_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vivekg, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Implementation of resource requests blocked by specific urls. Initial UI is hidden behind "blockedURLs" experiment. BUG=520259 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201079

Patch Set 1 #

Total comments: 1

Patch Set 2 : Explicit approach #

Total comments: 1

Patch Set 3 : removed unblock #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -1 line) Patch
M Source/core/inspector/InspectorResourceAgent.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 3 chunks +26 lines, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 3 chunks +65 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 1 2 3 3 chunks +39 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
dgozman
Take a look please.
5 years, 4 months ago (2015-08-20 20:51:04 UTC) #2
pfeldman
On 2015/08/20 20:51:04, dgozman wrote: > Take a look please. Screen?
5 years, 4 months ago (2015-08-21 01:37:34 UTC) #3
pfeldman
https://codereview.chromium.org/1295903005/diff/1/Source/core/inspector/InspectorResourceAgent.h File Source/core/inspector/InspectorResourceAgent.h (right): https://codereview.chromium.org/1295903005/diff/1/Source/core/inspector/InspectorResourceAgent.h#newcode86 Source/core/inspector/InspectorResourceAgent.h:86: bool shouldBlockRequest(const ResourceRequest&); Can we make it the other ...
5 years, 4 months ago (2015-08-21 01:38:46 UTC) #4
dgozman
On 2015/08/21 01:37:34, pfeldman wrote: > On 2015/08/20 20:51:04, dgozman wrote: > > Take a ...
5 years, 4 months ago (2015-08-21 01:56:57 UTC) #5
dgozman
PTAL
5 years, 4 months ago (2015-08-21 21:45:51 UTC) #6
pfeldman
instrumentation looks good, ui needs a screenshot. https://codereview.chromium.org/1295903005/diff/20001/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1295903005/diff/20001/Source/devtools/front_end/network/NetworkLogView.js#newcode1310 Source/devtools/front_end/network/NetworkLogView.js:1310: contextMenu.appendItem(blocked ? ...
5 years, 4 months ago (2015-08-21 22:05:33 UTC) #7
pfeldman
lgtm, but remove unblock.
5 years, 4 months ago (2015-08-21 22:09:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295903005/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295903005/50001
5 years, 4 months ago (2015-08-24 21:55:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103372)
5 years, 4 months ago (2015-08-24 22:59:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295903005/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295903005/50001
5 years, 4 months ago (2015-08-24 23:20:23 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 00:18:41 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201079

Powered by Google App Engine
This is Rietveld 408576698