Chromium Code Reviews| Index: chrome/browser/resources/settings/location_page/location_page.js |
| diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/location_page/location_page.js |
| similarity index 65% |
| copy from chrome/browser/resources/settings/privacy_page/privacy_page.js |
| copy to chrome/browser/resources/settings/location_page/location_page.js |
| index 1dce8a821a63bf8939fb5d2357f48e04a052955a..fceee65772d9e17c58f48c48455677c694348173 100644 |
| --- a/chrome/browser/resources/settings/privacy_page/privacy_page.js |
| +++ b/chrome/browser/resources/settings/location_page/location_page.js |
| @@ -4,22 +4,20 @@ |
| /** |
| * @fileoverview |
| - * 'cr-settings-privacy-page' is the settings page containing privacy and |
| + * 'cr-settings-location-page' is the settings page containing privacy and |
| * security settings. |
|
michaelpg
2015/08/17 21:09:58
location settings
dschuyler
2015/08/17 21:48:17
I tried to reword this to be more clear.
|
| * |
| * Example: |
| * |
| - * <iron-animated-pages> |
| - * <cr-settings-privacy-page prefs="{{prefs}}"> |
| - * </cr-settings-privacy-page> |
| + * <cr-settings-location-page prefs="{{prefs}}"> |
| + * </cr-settings-location-page> |
| * ... other pages ... |
| - * </iron-animated-pages> |
| * |
| * @group Chrome Settings Elements |
| - * @element cr-settings-privacy-page |
| + * @element cr-settings-location-page |
| */ |
| Polymer({ |
| - is: 'cr-settings-privacy-page', |
| + is: 'cr-settings-location-page', |
| properties: { |
| /** |
| @@ -40,7 +38,7 @@ Polymer({ |
| */ |
| subpage: { |
| type: Boolean, |
| - value: false, |
| + value: true, |
| readOnly: true, |
| }, |
| @@ -49,7 +47,7 @@ Polymer({ |
| */ |
| PAGE_ID: { |
| type: String, |
| - value: 'privacy', |
| + value: 'location', |
| readOnly: true, |
| }, |
| @@ -58,9 +56,7 @@ Polymer({ |
| */ |
| pageTitle: { |
| type: String, |
| - value: function() { |
| - return loadTimeData.getString('privacyPageTitle'); |
| - }, |
| + value: '', |
| }, |
| /** |
| @@ -68,8 +64,21 @@ Polymer({ |
| */ |
| icon: { |
| type: String, |
| - value: 'lock', |
| + value: 'communication:location-on', |
| readOnly: true, |
| }, |
| + |
| + block: { |
|
michaelpg
2015/08/17 21:09:58
Comment that these are arrays of URLs.
dschuyler
2015/08/17 21:48:18
Done.
|
| + type: Array, |
| + }, |
| + |
| + allow: { |
| + type: Array, |
| + }, |
| + }, |
| + |
| + ready: function() { |
| + this.block = []; |
| + this.allow = []; |
| }, |
| }); |