Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1295893005: Merge to XFA: Add new public APIs to find the z-order for links and widgets. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add new public APIs to find the z-order for links and widgets. - Implement FPDFLink_GetLinkZOrderAtPoint(). - Implement FPDFPage_FormFieldZOrderAtPoint(). - Mark FPDPage_HasFormFieldAtPoint() as deprecated. - Modify CPDF_LinkList and CPDF_InterForm to support new APIs. - Clean up dead code in CPDF_LinkList and CPDF_InterForm. BUG=chromium:515837 R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1278053004 . (cherry picked from commit 24fbf134d43a7ec4226de3db601f0a617bbe428b) Committed: https://pdfium.googlesource.com/pdfium/+/bdf72c353af5b8a34ef5efdeddfff36d2089a158

Patch Set 1 #

Total comments: 3

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -441 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 8 chunks +16 lines, -42 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 5 chunks +37 lines, -285 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +46 lines, -53 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 3 chunks +52 lines, -21 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +33 lines, -17 lines 0 comments Download
M fpdfsdk/src/fpdfview_c_api_test.c View 2 chunks +4 lines, -1 line 0 comments Download
M public/fpdf_doc.h View 1 1 chunk +37 lines, -12 lines 0 comments Download
M public/fpdf_formfill.h View 2 chunks +36 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
TBR https://codereview.chromium.org/1295893005/diff/1/core/src/fpdfdoc/doc_form.cpp File core/src/fpdfdoc/doc_form.cpp (left): https://codereview.chromium.org/1295893005/diff/1/core/src/fpdfdoc/doc_form.cpp#oldcode1332 core/src/fpdfdoc/doc_form.cpp:1332: if (pControl == NULL) { conflicted here. https://codereview.chromium.org/1295893005/diff/1/fpdfsdk/src/fpdfdoc.cpp ...
5 years, 4 months ago (2015-08-15 02:23:59 UTC) #1
Lei Zhang
5 years, 4 months ago (2015-08-15 02:24:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bdf72c353af5b8a34ef5efdeddfff36d2089a158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698