Add VisualBenchTestActivity for instrumentation-testing VisualBench

Add VisualBenchTestActivity for instrumentation-testing VisualBench

BUG=skia:4093
Committed: https://skia.googlesource.com/skia/+/e5e6c6069fb808626df0280cebc9399a950cdff7

[borenet, 2015-08-18 19:43:27]

borenet@google.com changed reviewers:
+ djsollen@google.com

[borenet, 2015-08-18 19:43:28]

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/visualbench/build.gradle (right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/build.gradle:9: minSdkVersion 17
Required for isDestroyed().

[djsollen, 2015-08-18 19:50:25]

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml:9:
<uses-sdk android:minSdkVersion="17" />
can we go to 19 to just be consistent with sampleApp?

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
File
platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java
(right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java:30:
Intent intent = new Intent(getInstrumentation().getTargetContext(),
VisualBenchActivity.class);
exceeds line limit

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
File platform_tools/android/gyp/skia_android.gypi (right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/skia_android.gypi:182: 'VisualBench_APK',
why do you want to build the app 2x?

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/skia_android.gypi:189:
'<(android_base)/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java',
add VisualbenchTestActivity as well

[borenet, 2015-08-18 20:03:11]

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/src/main/AndroidManifest.xml:9:
<uses-sdk android:minSdkVersion="17" />
On 2015/08/18 19:50:24, djsollen wrote:
> can we go to 19 to just be consistent with sampleApp?

Done.

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
File
platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java
(right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/apps...
platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java:30:
Intent intent = new Intent(getInstrumentation().getTargetContext(),
VisualBenchActivity.class);
On 2015/08/18 19:50:24, djsollen wrote:
> exceeds line limit

Done.

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
File platform_tools/android/gyp/skia_android.gypi (right):

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/skia_android.gypi:182: 'VisualBench_APK',
On 2015/08/18 19:50:25, djsollen wrote:
> why do you want to build the app 2x?

As discussed live, the tests seem to require a separate test app.

https://codereview.chromium.org/1295823004/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/skia_android.gypi:189:
'<(android_base)/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java',
On 2015/08/18 19:50:24, djsollen wrote:
> add VisualbenchTestActivity as well

Done.

[djsollen, 2015-08-18 20:05:30]

lgtm

[borenet, 2015-08-18 20:05:46]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-08-18 20:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295823004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295823004/20001

[commit-bot: I haz the power, 2015-08-18 20:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:09:55]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[borenet, 2015-08-19 18:58:52]

The CQ bit was checked by borenet@google.com

[borenet, 2015-08-19 18:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1295823004/#ps40001
(title: "Remove extra dependencies")

[commit-bot: I haz the power, 2015-08-19 18:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295823004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295823004/40001

[commit-bot: I haz the power, 2015-08-19 19:06:51]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e5e6c6069fb808626df0280cebc9399a950cdff7