LayoutTests/http/tests/websocket/bufferedAmount-after-send.html - Issue 1295723003: Fix a flaky websocket test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/bufferedAmount-after-send.html

Issue 1295723003: Fix a flaky websocket test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/websocket/bufferedAmount-after-send.html

diff --git a/LayoutTests/http/tests/websocket/bufferedAmount-after-send.html b/LayoutTests/http/tests/websocket/bufferedAmount-after-send.html

index 1dd2652928bac20dcd1170a8a9f9495643c7f299..8ad95e1ded237c992946e867dddf46474d29eb87 100644

--- a/LayoutTests/http/tests/websocket/bufferedAmount-after-send.html

+++ b/LayoutTests/http/tests/websocket/bufferedAmount-after-send.html

@@ -22,10 +22,11 @@ ws.onopen = function()

shouldBe('ws.bufferedAmount', '42');

ws.send('bye');

shouldBe('ws.bufferedAmount', '45');

- // FIXME: This is a bit flaky but I don't know how to fix it.

- setTimeout(function() {

- shouldBe('ws.bufferedAmount', '0');

- ws.close();

+ var id = setInterval(function() {

+ if (ws.bufferedAmount === 0) {

+ clearInterval(id);

+ ws.close();

+ }

}, 50);

};