Issue 1295713004: Untangle slots buffer part 1: Make invalid slots filtering part of MarkCompactCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1295713004: Untangle slots buffer part 1: Make invalid slots filtering part of MarkCompactCollector. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)

Modified:
5 years, 3 months ago

Reviewers:
Michael Lippautz

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Untangle slots buffer part 1: Make invalid slots filtering part of MarkCompactCollector. BUG=

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -75 lines)			Patch
	M	src/heap/mark-compact.h	View		3 chunks	+13 lines, -11 lines	0 comments	Download
	M	src/heap/mark-compact.cc	View		4 chunks	+52 lines, -64 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Lippautz

5 years, 4 months ago (2015-08-18 09:22:05 UTC) #3

lgtm

https://codereview.chromium.org/1295713004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1295713004/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:315: LargeObjectIterator it(heap->lo_space());
\o/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages