src/d8.js - Issue 12957004: ES6 symbols: turn symbols into a proper primitive type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.js

Issue 12957004: ES6 symbols: turn symbols into a proper primitive type (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.js

diff --git a/src/d8.js b/src/d8.js

index 1ff0ce8980dda2ed8843364eac299931a9a3dfec..8b30fcff8d9da82303568fb6be81bf565b847d43 100644

--- a/src/d8.js

+++ b/src/d8.js

@@ -2214,7 +2214,8 @@ function Stringify(x, depth) {

return x.toString();

case "string":

return "\"" + x.toString() + "\"";

- // TODO(rossberg): add symbol case

+ case "symbol":

+ return "Symbol()";

case "object":

if (x === null) return "null";

if (x.constructor && x.constructor.name === "Array") {

« no previous file with comments | « src/contexts.h ('k') | src/heap.h » ('j') | no next file with comments »