src/ia32/builtins-ia32.cc - Issue 12957004: ES6 symbols: turn symbols into a proper primitive type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 12957004: ES6 symbols: turn symbols into a proper primitive type (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index afb1c030ede170de9281e23d843e7fab563caaf5..ff5ee538780f1836c1679cba6a797361f1b2ed2b 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -409,10 +409,6 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,

__ CmpObjectType(eax, FIRST_SPEC_OBJECT_TYPE, ecx);

__ j(above_equal, &exit);

- // Symbols are "objects".

- __ CmpInstanceType(ecx, SYMBOL_TYPE);

- __ j(equal, &exit);

// Throw away the result of the constructor invocation and use the

// on-stack receiver as the result.

__ bind(&use_receiver);