Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 12957002: wd4-ui for try only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: wd4-ui_with_windows_fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index cc0b4f356f8c6c72aeeb0bddee57a88b8b7ef4ad..6ffaf1b02888d12816d12250685a554a4b08cae2 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -42,6 +42,7 @@
#include "chrome/browser/webdata/autofill_table.h"
#include "chrome/browser/webdata/web_data_service.h"
#include "chrome/browser/webdata/web_data_service_factory.h"
+#include "chrome/browser/webdata/web_data_service_test_util.h"
#include "chrome/browser/webdata/web_database.h"
#include "chrome/common/chrome_notification_types.h"
#include "components/autofill/browser/autofill_common_test.h"
@@ -94,7 +95,7 @@ class HistoryService;
class AutofillTableMock : public AutofillTable {
public:
- AutofillTableMock() : AutofillTable(NULL, NULL) {}
+ AutofillTableMock() : AutofillTable() {}
MOCK_METHOD2(RemoveFormElement,
bool(const string16& name, const string16& value)); // NOLINT
MOCK_METHOD1(GetAllAutofillEntries,
@@ -119,18 +120,11 @@ MATCHER_P(MatchProfiles, profile, "") {
return (profile.Compare(arg) == 0);
}
-
class WebDatabaseFake : public WebDatabase {
public:
- explicit WebDatabaseFake(AutofillTable* autofill_table)
- : autofill_table_(autofill_table) {}
-
- virtual AutofillTable* GetAutofillTable() OVERRIDE {
- return autofill_table_;
+ explicit WebDatabaseFake(AutofillTable* autofill_table) {
+ AddTable(autofill_table);
}
-
- private:
- AutofillTable* autofill_table_;
};
class ProfileSyncServiceAutofillTest;
@@ -157,10 +151,6 @@ class WebDataServiceFake : public WebDataService {
syncable_service_created_or_destroyed_(false, false) {
}
- static scoped_refptr<RefcountedProfileKeyedService> Build(Profile* profile) {
- return new WebDataServiceFake;
- }
-
void SetDatabase(WebDatabase* web_database) {
web_database_ = web_database;
}
@@ -219,8 +209,6 @@ class WebDataServiceFake : public WebDataService {
return autofill_profile_syncable_service_;
}
- virtual void ShutdownOnUIThread() OVERRIDE {}
-
private:
virtual ~WebDataServiceFake() {}
@@ -249,6 +237,10 @@ class WebDataServiceFake : public WebDataService {
WaitableEvent syncable_service_created_or_destroyed_;
};
+ProfileKeyedService* BuildMockWebDataServiceWrapper(Profile* profile) {
+ return new MockWebDataServiceWrapper(new WebDataServiceFake());
+}
+
ACTION_P(MakeAutocompleteSyncComponents, wds) {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
if (!BrowserThread::CurrentlyOn(BrowserThread::DB))
@@ -410,9 +402,12 @@ class ProfileSyncServiceAutofillTest
profile_.reset(new ProfileMock());
profile_->CreateRequestContext();
web_database_.reset(new WebDatabaseFake(&autofill_table_));
- web_data_service_ = static_cast<WebDataServiceFake*>(
- WebDataServiceFactory::GetInstance()->SetTestingFactoryAndUse(
- profile_.get(), WebDataServiceFake::Build).get());
+ MockWebDataServiceWrapper* wrapper =
+ static_cast<MockWebDataServiceWrapper*>(
+ WebDataServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+ profile_.get(), BuildMockWebDataServiceWrapper));
+ web_data_service_ =
+ static_cast<WebDataServiceFake*>(wrapper->GetWebData().get());
web_data_service_->SetDatabase(web_database_.get());
MockPersonalDataManagerService* personal_data_manager_service =

Powered by Google App Engine
This is Rietveld 408576698