content/browser/renderer_host/legacy_render_widget_host_win.cc - Issue 1295683003: Remove the CHECK from the DirectManipulationHelper::Activate function as it is firing in Canary on …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/legacy_render_widget_host_win.cc

Issue 1295683003: Remove the CHECK from the DirectManipulationHelper::Activate function as it is firing in Canary on … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/legacy_render_widget_host_win.cc

diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.cc b/content/browser/renderer_host/legacy_render_widget_host_win.cc

index 8dcdaf63c98cd899bbae46fbbcb7a77e848774ce..b9f2cc9b21b46da8519e75ae055e6132f215caed 100644

--- a/content/browser/renderer_host/legacy_render_widget_host_win.cc

+++ b/content/browser/renderer_host/legacy_render_widget_host_win.cc

@@ -82,6 +82,8 @@ void LegacyRenderWidgetHostHWND::Show() {

void LegacyRenderWidgetHostHWND::Hide() {

::ShowWindow(hwnd(), SW_HIDE);

+ if (direct_manipulation_helper_)

+ direct_manipulation_helper_->Deactivate(hwnd());

}

void LegacyRenderWidgetHostHWND::SetBounds(const gfx::Rect& bounds) {

« no previous file with comments | « no previous file | ui/gfx/win/direct_manipulation.h » ('j') | ui/views/win/hwnd_message_handler.cc » ('J')