Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1295673002: Re-enable LLVM LTO for ARM. (Closed)

Created:
5 years, 4 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
pcc, rmcilroy, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-enable LLVM LTO for ARM. v8 is optimized for speed. Because GCC LTO merges flags at link time, we disable LTO to prevent any -O2 flags from taking precedence over v8's -Os flag. However, LLVM LTO does not work this way so we keep LTO enabled under LLVM. This fixes the ARM build in the cfi_vptr==1 configuration, which requires LLVM LTO. R=adamk@chromium.org BUG=chromium:469376 LOG=N Committed: https://crrev.com/fef4fab6bb2844ddc0af1c8243df81666ebd4799 Cr-Commit-Position: refs/heads/master@{#30455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/toolchain.gypi View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pcc1
5 years, 4 months ago (2015-08-13 22:59:58 UTC) #1
pcc1
Ping.
5 years, 3 months ago (2015-08-28 18:32:03 UTC) #3
adamk
rubberstamp lgtm as this follows similar patches elsewhere in Chromium
5 years, 3 months ago (2015-08-28 22:42:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295673002/1
5 years, 3 months ago (2015-08-28 22:43:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5359)
5 years, 3 months ago (2015-08-28 22:46:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295673002/1
5 years, 3 months ago (2015-08-28 22:47:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 23:05:36 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 23:05:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef4fab6bb2844ddc0af1c8243df81666ebd4799
Cr-Commit-Position: refs/heads/master@{#30455}

Powered by Google App Engine
This is Rietveld 408576698