Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1295663003: Check for duplicate files and other common issues. (Closed)

Created:
5 years, 4 months ago by Johann
Modified:
5 years, 4 months ago
Reviewers:
jzern, Tom Finegan
CC:
chromium-reviews, wwcv, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for duplicate files and other common issues. Remove the vp10 directory to avoid having a whole ton of unused files. --ignore-unmatch when using git rm so the script doesn't crash and exit early. Clarify why the scripts are upgraded to executable. Search for files duplicated between vpx_dsp, vp8, and vp9 and warn. In most cases this will cause build failures because currently none of the build systems (including upstream) handle this case well. R=tomfinegan@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/164c5808ca57eed4c38056c1adcef4e1a582b913

Patch Set 1 #

Total comments: 3

Patch Set 2 : use different searching options #

Total comments: 1

Patch Set 3 : escape period #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M update_libvpx.sh View 1 2 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Johann
wdyt?
5 years, 4 months ago (2015-08-18 23:44:36 UTC) #1
jzern
https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh File update_libvpx.sh (right): https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh#newcode129 update_libvpx.sh:129: find vp8 vp9 -name $(basename $file); done) you could ...
5 years, 4 months ago (2015-08-18 23:50:34 UTC) #3
Johann
https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh File update_libvpx.sh (right): https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh#newcode129 update_libvpx.sh:129: find vp8 vp9 -name $(basename $file); done) On 2015/08/18 ...
5 years, 4 months ago (2015-08-18 23:57:01 UTC) #4
Johann
https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh File update_libvpx.sh (right): https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh#newcode129 update_libvpx.sh:129: find vp8 vp9 -name $(basename $file); done) On 2015/08/18 ...
5 years, 4 months ago (2015-08-19 00:00:17 UTC) #5
jzern
On 2015/08/19 00:00:17, Johann wrote: > https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh > File update_libvpx.sh (right): > > https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh#newcode129 > ...
5 years, 4 months ago (2015-08-19 00:19:23 UTC) #6
jzern
On 2015/08/19 00:19:23, jzern wrote: > On 2015/08/19 00:00:17, Johann wrote: > > https://codereview.chromium.org/1295663003/diff/1/update_libvpx.sh > ...
5 years, 4 months ago (2015-08-19 00:22:37 UTC) #7
Johann
On 2015/08/19 00:22:37, jzern wrote: > On 2015/08/19 00:19:23, jzern wrote: > > On 2015/08/19 ...
5 years, 4 months ago (2015-08-20 19:19:16 UTC) #8
Johann
On 2015/08/20 19:19:16, Johann wrote: > On 2015/08/19 00:22:37, jzern wrote: > > On 2015/08/19 ...
5 years, 4 months ago (2015-08-20 19:19:44 UTC) #9
jzern
https://codereview.chromium.org/1295663003/diff/20001/update_libvpx.sh File update_libvpx.sh (right): https://codereview.chromium.org/1295663003/diff/20001/update_libvpx.sh#newcode128 update_libvpx.sh:128: egrep -v '(^exports_(dec|enc)|.h)$' | \ you could do something ...
5 years, 4 months ago (2015-08-20 20:14:18 UTC) #10
Johann
5 years, 4 months ago (2015-08-20 21:09:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
164c5808ca57eed4c38056c1adcef4e1a582b913 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698