Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 129563002: GN: Fix Mac build for some tests. (Closed)

Created:
6 years, 11 months ago by bbudge
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

GN: Fix Mac build for some tests. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243738

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M tools/gn/secondary/testing/gtest/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/third_party/mach_override/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
With this CL, I can build the ipc_tests and ipc_perftests targets.
6 years, 11 months ago (2014-01-08 22:08:59 UTC) #1
brettw
lgtm
6 years, 11 months ago (2014-01-08 22:42:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/129563002/50001
6 years, 11 months ago (2014-01-08 22:49:15 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 01:50:06 UTC) #4
Message was sent while issue was closed.
Change committed as 243738

Powered by Google App Engine
This is Rietveld 408576698