Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1295573002: Address test slowness with Cache Storage match()/matchAll() tests (Closed)

Created:
5 years, 4 months ago by jsbell
Modified:
5 years, 4 months ago
Reviewers:
jkarlin, nhiroki
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Address test slowness with Cache Storage match()/matchAll() tests The test cases initially ran in parallel, but the web-platform-tests' promise_test() switched to running cases serially for predictability, which made these tests with many cases and lots of setup time out. * Split up the match() and matchAll() tests into separate files * Do the pre-population of the caches (within each test) in parallel BUG=508984 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -407 lines) Patch
M LayoutTests/SlowTests View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/resources/test-helpers.js View 1 chunk +150 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-match.js View 12 chunks +0 lines, -312 lines 0 comments Download
A LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js View 1 chunk +164 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/serviceworker/cache-match.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cachestorage/serviceworker/cache-match-expected.txt View 1 chunk +1 line, -12 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll-expected.txt View 1 chunk +1 line, -15 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/window/cache-match.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/window/cache-matchAll.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/worker/cache-match.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cachestorage/worker/cache-match-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/worker/cache-matchAll.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
jsbell
nhiroki@, jkarlin@ - please take a look?
5 years, 4 months ago (2015-08-14 16:01:21 UTC) #2
jsbell
nhiroki@, jkarlin@ - please take a look?
5 years, 4 months ago (2015-08-14 16:01:22 UTC) #3
jkarlin
lgtm
5 years, 4 months ago (2015-08-14 16:18:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295573002/1
5 years, 4 months ago (2015-08-14 16:45:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93370)
5 years, 4 months ago (2015-08-14 18:01:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295573002/1
5 years, 4 months ago (2015-08-14 18:26:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93467)
5 years, 4 months ago (2015-08-14 20:20:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295573002/1
5 years, 4 months ago (2015-08-14 20:21:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93544)
5 years, 4 months ago (2015-08-14 21:50:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295573002/1
5 years, 4 months ago (2015-08-18 20:06:02 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 21:18:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200754

Powered by Google App Engine
This is Rietveld 408576698