Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1295553002: Revert of Better handle reentrancy into DocumentLoader::dataReceived(). (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, kinuko+watch, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Better handle reentrancy into DocumentLoader::dataReceived(). (patchset #10 id:180001 of https://codereview.chromium.org/1263363005/ ) Reason for revert: ASan bots are reporting a handful of UAFs, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/19837 Original issue's description: > Better handle reentrancy into DocumentLoader::dataReceived(). > > dataReceived() can be called reentrantly if it triggers a nested message > loop when detaching a Document or parsing script for the new Document. > Since dataReceived() isn't safe for reentrancy, any nested invocations > queue the received data to be processed by the top-level invocation of > dataReceived(). > > BUG=515876 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200436 TBR=japhet@chromium.org,kouhei@chromium.org,morrita@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=515876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -211 lines) Patch
M Source/core/loader/DocumentLoader.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 3 chunks +0 lines, -33 lines 0 comments Download
D Source/web/tests/DocumentLoaderTest.cpp View 1 chunk +0 lines, -171 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sof
Created Revert of Better handle reentrancy into DocumentLoader::dataReceived().
5 years, 4 months ago (2015-08-13 20:03:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295553002/1
5 years, 4 months ago (2015-08-13 20:04:08 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 20:04:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200487

Powered by Google App Engine
This is Rietveld 408576698