android_webview/browser/net/aw_url_request_job_factory.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/net/aw_url_request_job_factory.cc

diff --git a/android_webview/browser/net/aw_url_request_job_factory.cc b/android_webview/browser/net/aw_url_request_job_factory.cc

index 984458cd80285652a8267b70abe56d617d9b14aa..d0c64a16c16380b35c281997a08fa0e28c58c1a5 100644

--- a/android_webview/browser/net/aw_url_request_job_factory.cc

+++ b/android_webview/browser/net/aw_url_request_job_factory.cc

@@ -74,7 +74,8 @@ net::URLRequestJob* AwURLRequestJobFactory::MaybeInterceptResponse(

bool AwURLRequestJobFactory::SetProtocolHandler(

const std::string& scheme,

ProtocolHandler* protocol_handler) {

- return next_factory_->SetProtocolHandler(scheme, protocol_handler);

+ return next_factory_->SetProtocolHandler(scheme,

+ make_scoped_ptr(protocol_handler));

}

bool AwURLRequestJobFactory::IsSafeRedirectTarget(const GURL& location) const {

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | chrome/browser/profiles/profile_io_data.cc » ('J')