net/url_request/url_request_test_job.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_test_job.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_test_job.cc

diff --git a/net/url_request/url_request_test_job.cc b/net/url_request/url_request_test_job.cc

index 9ca0f5aff3796e55d76cd87e30de2a6a1ea2a576..7530d42bb7a3b824a1cc27ec3ac56d6b51390b58 100644

--- a/net/url_request/url_request_test_job.cc

+++ b/net/url_request/url_request_test_job.cc

@@ -110,9 +110,9 @@ std::string URLRequestTestJob::test_error_headers() {

}

// static

-URLRequestJobFactory::ProtocolHandler*

+scoped_ptr<URLRequestJobFactory::ProtocolHandler>

URLRequestTestJob::CreateProtocolHandler() {

- return new TestJobProtocolHandler();

+ return make_scoped_ptr(new TestJobProtocolHandler());

}

URLRequestTestJob::URLRequestTestJob(URLRequest* request,

« no previous file with comments | « net/url_request/url_request_test_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »