Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: net/url_request/url_request_simple_job_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing un-modified file Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_job_factory_impl_unittest.cc ('k') | net/url_request/url_request_test_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_simple_job_unittest.cc
diff --git a/net/url_request/url_request_simple_job_unittest.cc b/net/url_request/url_request_simple_job_unittest.cc
index abccbe050c329b02636d8e6f5d52c7fac89bb86e..1286977b9cd6037b0b9857eb3620b2f4ee8f591a 100644
--- a/net/url_request/url_request_simple_job_unittest.cc
+++ b/net/url_request/url_request_simple_job_unittest.cc
@@ -105,10 +105,10 @@ class SimpleJobProtocolHandler :
kTestData);
}
+ ~SimpleJobProtocolHandler() override {}
+
private:
scoped_refptr<base::TaskRunner> task_runner_;
-
- ~SimpleJobProtocolHandler() override {}
};
class URLRequestSimpleJobTest : public ::testing::Test {
@@ -120,8 +120,8 @@ class URLRequestSimpleJobTest : public ::testing::Test {
worker_pool_->GetSequenceToken(),
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)),
context_(true) {
- job_factory_.SetProtocolHandler("data",
- new SimpleJobProtocolHandler(task_runner_));
+ job_factory_.SetProtocolHandler(
+ "data", make_scoped_ptr(new SimpleJobProtocolHandler(task_runner_)));
context_.set_job_factory(&job_factory_);
context_.Init();
« no previous file with comments | « net/url_request/url_request_job_factory_impl_unittest.cc ('k') | net/url_request/url_request_test_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698