ios/net/protocol_handler_util_unittest.mm - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/protocol_handler_util_unittest.mm

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/net/protocol_handler_util_unittest.mm

diff --git a/ios/net/protocol_handler_util_unittest.mm b/ios/net/protocol_handler_util_unittest.mm

index da39df6fd37e6f053df45b72f3341b5ae09639f3..1193dc75a66dd4ab50d33673ae56ae861102a7a5 100644

--- a/ios/net/protocol_handler_util_unittest.mm

+++ b/ios/net/protocol_handler_util_unittest.mm

@@ -110,8 +110,10 @@ class ProtocolHandlerUtilTest : public testing::Test,

public:

ProtocolHandlerUtilTest() : request_context_(new TestURLRequestContext) {

// Ownership of the protocol handlers is transferred to the factory.

- job_factory_.SetProtocolHandler("http", new NetProtocolHandler);

- job_factory_.SetProtocolHandler("data", new DataProtocolHandler);

+ job_factory_.SetProtocolHandler("http",

+ make_scoped_ptr(new NetProtocolHandler));

+ job_factory_.SetProtocolHandler("data",

+ make_scoped_ptr(new DataProtocolHandler));

request_context_->set_job_factory(&job_factory_);

}

« no previous file with comments | « ios/crnet/crnet_environment.mm ('k') | ios/web/net/request_tracker_impl_unittest.mm » ('j') | no next file with comments »