components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing un-modified file Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/url_request_context_factory.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc

diff --git a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc

index 7845c0582d83b1f3e73c77ce9e5c0e1a05682809..4ca477e29574262f45d3322590d24a0168fc7037 100644

--- a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc

+++ b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc

@@ -59,10 +59,8 @@ class DataReductionProxyDebugResourceThrottleTest : public testing::Test {

DataReductionProxyDebugResourceThrottleTest() : context_(true) {

context_.Init();

- // The |test_job_factory_| takes ownership of the interceptor.

- test_job_interceptor_ = new net::TestJobInterceptor();

- EXPECT_TRUE(test_job_factory_.SetProtocolHandler(url::kHttpScheme,

- test_job_interceptor_));

+ EXPECT_TRUE(test_job_factory_.SetProtocolHandler(

+ url::kHttpScheme, make_scoped_ptr(new net::TestJobInterceptor())));

context_.set_job_factory(&test_job_factory_);

@@ -108,8 +106,6 @@ class DataReductionProxyDebugResourceThrottleTest : public testing::Test {

base::MessageLoop message_loop_;

net::TestURLRequestContext context_;

net::TestDelegate delegate_;

- // |test_job_interceptor_| is owned by |test_job_factory_|.

- net::TestJobInterceptor* test_job_interceptor_;

net::URLRequestJobFactoryImpl test_job_factory_;

net::ProxyConfig proxy_config_;