Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: Source/devtools/front_end/ui/KeyboardShortcut.js

Issue 1295523003: DevTools: do not use arrow functions unless they are in stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/KeyboardShortcut.js
diff --git a/Source/devtools/front_end/ui/KeyboardShortcut.js b/Source/devtools/front_end/ui/KeyboardShortcut.js
index dd849bddefc4361c267895172174ef4418a71bba..fa3c484367eae0da0b1510ba1254145aba4b5af3 100644
--- a/Source/devtools/front_end/ui/KeyboardShortcut.js
+++ b/Source/devtools/front_end/ui/KeyboardShortcut.js
@@ -292,7 +292,16 @@ WebInspector.KeyboardShortcut._modifiersToString = function(modifiers)
[m.Shift, isMac ? "\u21e7" : "Shift\u200A+\u200A"],
[m.Meta, isMac ? "\u2318" : "Win\u200A+\u200A"]
]);
- return [m.Ctrl, m.Alt, m.Shift, m.Meta].map(m => modifiers & m ? modifierNames.get(m) : "").join("");
+ return [m.Ctrl, m.Alt, m.Shift, m.Meta].map(mapModifiers).join("");
+
+ /**
+ * @param {number} m
+ * @return {string}
+ */
+ function mapModifiers(m)
+ {
+ return modifiers & m ? /** @type {string} */ (modifierNames.get(m)) : "";
+ }
};
WebInspector.KeyboardShortcut.SelectAll = WebInspector.KeyboardShortcut.makeKey("a", WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta);
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698