Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295523003: DevTools: do not use arrow functions unless they are in stable. (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
Reviewers:
alph, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not use arrow functions unless they are in stable. BUG=515928 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200568

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +11 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/KeyboardShortcut.js View 1 1 chunk +10 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
pfeldman
5 years, 4 months ago (2015-08-14 16:45:27 UTC) #2
alph
lgtm
5 years, 4 months ago (2015-08-14 16:48:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523003/1
5 years, 4 months ago (2015-08-14 16:48:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523003/20001
5 years, 4 months ago (2015-08-14 17:00:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93376)
5 years, 4 months ago (2015-08-14 18:45:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523003/20001
5 years, 4 months ago (2015-08-14 18:57:00 UTC) #12
paulirish
Can we merge this back to 45?
5 years, 4 months ago (2015-08-14 19:22:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93484)
5 years, 4 months ago (2015-08-14 21:12:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523003/20001
5 years, 4 months ago (2015-08-14 21:51:37 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 21:56:59 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200568

Powered by Google App Engine
This is Rietveld 408576698