Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1295523002:
stop dropping AA when rect stays rect (Closed)
|
Created:
5 years, 4 months ago by joshua.litt Modified:
5 years, 4 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionstop dropping AA when rect stays rect
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/1bef9f59c566cc54c2259cc4d0171c115157cd1c
Committed: https://skia.googlesource.com/skia/+/9be0b002caaf4f44e04873351f957c3e97922457
Patch Set 1 #Patch Set 2 : tweaks #Patch Set 3 : feedback inc #
Total comments: 1
Patch Set 4 : feedback inc #Patch Set 5 : tweaks #
Total comments: 2
Patch Set 6 : tweaks #Patch Set 7 : tweaks #Patch Set 8 : clean #Messages
Total messages: 22 (9 generated)
joshualitt@google.com changed reviewers: + bsalomon@google.com
joshualitt@google.com changed reviewers: + joshualitt@google.com
this should help with batching
On 2015/08/13 17:48:40, joshualitt wrote: > this should help with batching lgtm
joshualitt@google.com changed reviewers: + robertphillips@google.com
ptal
https://codereview.chromium.org/1295523002/diff/40001/src/gpu/GrDrawContext.cpp File src/gpu/GrDrawContext.cpp (left): https://codereview.chromium.org/1295523002/diff/40001/src/gpu/GrDrawContext.c... src/gpu/GrDrawContext.cpp:219: if (pipelineBuilder->getRenderTarget()->isUnifiedMultisampled() || So the new rect batches can handle AA rotation and perspective?
On 2015/08/13 18:33:05, robertphillips wrote: > https://codereview.chromium.org/1295523002/diff/40001/src/gpu/GrDrawContext.cpp > File src/gpu/GrDrawContext.cpp (left): > > https://codereview.chromium.org/1295523002/diff/40001/src/gpu/GrDrawContext.c... > src/gpu/GrDrawContext.cpp:219: if > (pipelineBuilder->getRenderTarget()->isUnifiedMultisampled() || > So the new rect batches can handle AA rotation and perspective? feedback inc
lgtm https://codereview.chromium.org/1295523002/diff/80001/src/gpu/GrDrawContext.cpp File src/gpu/GrDrawContext.cpp (right): https://codereview.chromium.org/1295523002/diff/80001/src/gpu/GrDrawContext.c... src/gpu/GrDrawContext.cpp:275: // at all yet. // The fill path can handle rotation but not skew // The stroke path needs the rect to remain axis aligned (no rotation or skew) ? https://codereview.chromium.org/1295523002/diff/80001/src/gpu/GrDrawContext.c... src/gpu/GrDrawContext.cpp:276: SkASSERT(!viewMatrix.hasPerspective()); Extra space after ':' ?
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com, robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1295523002/#ps120001 (title: "tweaks")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com, robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1295523002/#ps140001 (title: "clean")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523002/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/1bef9f59c566cc54c2259cc4d0171c115157cd1c
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/1295813005/ by joshualitt@google.com. The reason for reverting is: breaks layout tests.
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295523002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295523002/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/9be0b002caaf4f44e04873351f957c3e97922457 |
