Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 12955002: Correction for gm --config usage text (default configs). (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
scroggo, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Correction for gm --config usage text (default configs). Rename debug -> debuggpu. Make debuggpu a default only in debug builds.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M gm/gmmain.cpp View 3 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
7 years, 9 months ago (2013-03-20 14:42:32 UTC) #1
scroggo
lgtm
7 years, 9 months ago (2013-03-20 14:50:52 UTC) #2
scroggo
7 years, 9 months ago (2013-03-20 15:22:16 UTC) #3
On 2013/03/20 14:50:52, scroggo wrote:
> lgtm

Actually, you can move the config string into the same line as config. See
https://codereview.chromium.org/12663021/

Powered by Google App Engine
This is Rietveld 408576698