Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: net/spdy/spdy_stream.h

Issue 129543002: Enable SpdyStream's HALF_CLOSED_REMOTE state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add add'l weak_this guard around delegate calls (2nd try). Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_network_transaction_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index 083225cb9590fb4e6a998b07bf613fba38d9defc..a8cc7dcde3a6648fb21a1185e73f88291ac87adb 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -395,9 +395,7 @@ class NET_EXPORT_PRIVATE SpdyStream {
// Returns whether this stream is IDLE: request and response headers
// have neither been sent nor receieved.
- // TODO(jgraettinger): Renamed to force compilation error & semantics
- // update at call sites. Undo this.
- bool IsIdleTemporaryRename() const;
+ bool IsIdle() const;
// Returns whether or not this stream is fully open: that request and
// response headers are complete, and it is not in a half-closed state.
@@ -444,13 +442,12 @@ class NET_EXPORT_PRIVATE SpdyStream {
// a remote SYN_STREAM (the client can only initate streams).
// TODO(jgraettinger): RESERVED_REMOTE must be added to the state
// machine when PUSH_PROMISE is implemented.
- // TODO(jgraettinger): HALF_CLOSED_REMOTE must be added to the state
- // machine to support remotely closed, ongoing sends.
enum State {
STATE_IDLE,
STATE_OPEN,
STATE_HALF_CLOSED_LOCAL_UNCLAIMED,
STATE_HALF_CLOSED_LOCAL,
+ STATE_HALF_CLOSED_REMOTE,
STATE_CLOSED,
};
« no previous file with comments | « net/spdy/spdy_network_transaction_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698