Add ProcessControlImpl, the default ProcessControl implementation.

Add ProcessControlImpl, the default ProcessControl implementation.

Refactor UtilityProcessControlImpl and move common (non-utility-specific) code
into a base class ProcessControlImpl. UtilityProcessControlImpl inherits
ProcessControlImpl and has the utility specific code. This allows us to easily
add ProcessControl implementation to other processes, e.g. the GPU process.

BUG=521755
Committed: https://crrev.com/e88fc6f755bd832ba009fe7733ab553d59e759ac
Cr-Commit-Position: refs/heads/master@{#344402}

[xhwang, 2015-08-18 23:11:49]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org, rockot@chromium.org

[xhwang, 2015-08-18 23:12:15]

rockot: Please review everything.
jam: Please OWNERS review.

[jam, 2015-08-19 15:52:46]

which other processes do you see ProcessControlImpl used in? You mentioned GPU,
any others?

If only child processes, i.e. non-browser, then the base class should go into
content/child. common is for sharing code between child and browser process.

[xhwang, 2015-08-19 16:38:46]

comments addressed

[xhwang, 2015-08-19 16:39:41]

On 2015/08/19 15:52:46, jam wrote:
> which other processes do you see ProcessControlImpl used in? You mentioned
GPU,
> any others?

Yes, it's intended to be used for Child process only.
 
> If only child processes, i.e. non-browser, then the base class should go into
> content/child. common is for sharing code between child and browser process.

Good point. Done.

PTAL again.

[jam, 2015-08-19 23:01:09]

lgtm

[Ken Rockot(use gerrit already), 2015-08-19 23:07:34]

lgtm

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
File content/child/process_control_impl.cc (right):

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
content/child/process_control_impl.cc:9: #include
"mojo/shell/static_application_loader.h"
This shouldn't be necessary (and so you can also remove mojo/shell from DEPS)

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
File content/child/process_control_impl.h (right):

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
content/child/process_control_impl.h:43: bool has_registered_loaders = false;
nit: has_registered_loaders_

[xhwang, 2015-08-20 00:23:56]

comments addressed

[xhwang, 2015-08-20 00:43:34]

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
File content/child/process_control_impl.cc (right):

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
content/child/process_control_impl.cc:9: #include
"mojo/shell/static_application_loader.h"
On 2015/08/19 23:07:34, Ken Rockot wrote:
> This shouldn't be necessary (and so you can also remove mojo/shell from DEPS)

I actually need it for the Load() call on l.40.

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
File content/child/process_control_impl.h (right):

https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
content/child/process_control_impl.h:43: bool has_registered_loaders = false;
On 2015/08/19 23:07:34, Ken Rockot wrote:
> nit: has_registered_loaders_

Done.

[xhwang, 2015-08-20 00:43:37]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-08-20 00:43:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1295363003/#ps80001
(title: "comments addressed")

[commit-bot: I haz the power, 2015-08-20 00:44:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295363003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295363003/80001

[Ken Rockot(use gerrit already), 2015-08-20 00:47:32]

On 2015/08/20 00:43:34, xhwang wrote:
>
https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
> File content/child/process_control_impl.cc (right):
> 
>
https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
> content/child/process_control_impl.cc:9: #include
> "mojo/shell/static_application_loader.h"
> On 2015/08/19 23:07:34, Ken Rockot wrote:
> > This shouldn't be necessary (and so you can also remove mojo/shell from
DEPS)
> 
> I actually need it for the Load() call on l.40.

Doh - I overlooked URLToLoaderMap...

> 
>
https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
> File content/child/process_control_impl.h (right):
> 
>
https://codereview.chromium.org/1295363003/diff/60001/content/child/process_c...
> content/child/process_control_impl.h:43: bool has_registered_loaders = false;
> On 2015/08/19 23:07:34, Ken Rockot wrote:
> > nit: has_registered_loaders_
> 
> Done.

[commit-bot: I haz the power, 2015-08-20 01:45:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-20 01:46:10]

Patchset 5 (id:??) landed as
https://crrev.com/e88fc6f755bd832ba009fe7733ab553d59e759ac
Cr-Commit-Position: refs/heads/master@{#344402}