Port CrashReportUploadThread to Windows

handler/crash_report_upload_thread.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef CRASHPAD_HANDLER_MAC_CRASH_REPORT_UPLOAD_THREAD_H_
-#define CRASHPAD_HANDLER_MAC_CRASH_REPORT_UPLOAD_THREAD_H_
+#ifndef CRASHPAD_HANDLER_CRASH_REPORT_UPLOAD_THREAD_H_
+#define CRASHPAD_HANDLER_CRASH_REPORT_UPLOAD_THREAD_H_
 
 #include "base/basictypes.h"
 
-#include <pthread.h>
-
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
 #include "client/crash_report_database.h"
 #include "util/synchronization/semaphore.h"
 
 namespace crashpad {
 
+class HelperThread;

[Mark Mentovai, 2015/08/18 21:38:12]

Since this is just in namespace crashpad, you should probably name it
CrashReportUploadHelperThread so that it’s a little more obvious. Bonus points
for putting it in crashpad::internal.

[scottmg, 2015/08/18 22:21:40]

Done.

+
 //! \brief A thread that processes pending crash reports in a
 //!     CrashReportDatabase by uploading them or marking them as completed
 //!     without upload, as desired.
 //!
 //! A producer of crash reports should notify an object of this class that a new
 //! report has been added to the database by calling ReportPending().
 //!
 //! Independently of being triggered by ReportPending(), objects of this class
 //! periodically examine the database for pending reports. This allows failed
 //! upload attempts for reports left in the pending state to be retried. It also
@@ skipping 30 matching lines @@
   //! It is expected to only be called from the same thread that called Start().
   void Stop();
 
   //! \brief Informs the upload thread that a new pending report has been added
   //!     to the database.
   //!
   //! This method may be called from any thread.
   void ReportPending();
 
  private:
+  friend class HelperThread;
+
   //! \brief The result code from UploadReport().
   enum class UploadResult {
     //! \brief The crash report was uploaded successfully.
     kSuccess,
 
     //! \brief The crash report upload failed in such a way that recovery is
     //!     impossible.
     //!
     //! No further upload attempts should be made for the report.
     kPermanentFailure,
@@ skipping 37 matching lines @@
   //!     CrashReportDatabase::RecordUploadAttempt() after calling this method.
   //! \param[out] response_body If the upload attempt is successful, this will
   //!     be set to the response body sent by the server. Breakpad-type servers
   //!     provide the crash ID assigned by the server in the response body.
   //!
   //! \return A member of UploadResult indicating the result of the upload
   //!    attempt.
   UploadResult UploadReport(const CrashReportDatabase::Report* report,
                             std::string* response_body);
 
-  //! \brief Cals ThreadMain().
-  //!
-  //! \param[in] arg A pointer to the object on which to invoke ThreadMain().
-  //!
-  //! \return `nullptr`.
-  static void* RunThreadMain(void* arg);
-
   std::string url_;
   CrashReportDatabase* database_;  // weak
   Semaphore semaphore_;  // TODO(mark): Use a condition variable instead?
-  pthread_t thread_;
+  scoped_ptr<HelperThread> thread_;
   bool running_;
 };
 
 }  // namespace crashpad
 
-#endif  // CRASHPAD_HANDLER_MAC_CRASH_REPORT_UPLOAD_THREAD_H_
+#endif  // CRASHPAD_HANDLER_CRASH_REPORT_UPLOAD_THREAD_H_