Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 129533003: Remove the RTP recording related code from webrtc-internals. (Closed)

Created:
6 years, 11 months ago by jiayl
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the RTP recording related code from webrtc-internals. The code is dead and we have no plan to implement RTP recording in the near term. So removing to avoid confusion. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -142 lines) Patch
M content/browser/media/webrtc_internals.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/media/webrtc_internals.cc View 3 chunks +1 line, -26 lines 0 comments Download
M content/browser/media/webrtc_internals_message_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_internals_message_handler.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M content/browser/resources/media/dump_creator.js View 6 chunks +2 lines, -79 lines 0 comments Download
M content/browser/resources/media/webrtc_internals.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jiayl
6 years, 11 months ago (2014-01-08 21:48:44 UTC) #1
vrk (LEFT CHROMIUM)
LGTM, thanks for doing this cleanup!
6 years, 11 months ago (2014-01-09 00:27:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/129533003/1
6 years, 11 months ago (2014-01-09 00:33:42 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:54:26 UTC) #4
Message was sent while issue was closed.
Change committed as 243876

Powered by Google App Engine
This is Rietveld 408576698