Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295303006: gn build: check use_udev before depending on udev (Closed)

Created:
5 years, 4 months ago by Mostyn Bramley-Moore
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn build: check use_udev before depending on udev Committed: https://crrev.com/ea51468614165ef8cdc3ec1317cb941e44335098 Cr-Commit-Position: refs/heads/master@{#344047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295303006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295303006/1
5 years, 4 months ago (2015-08-18 20:36:38 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 21:08:06 UTC) #4
Mostyn Bramley-Moore
@brettw: does this look OK to you?
5 years, 4 months ago (2015-08-18 21:36:36 UTC) #6
brettw
lgtm
5 years, 4 months ago (2015-08-18 21:40:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295303006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295303006/1
5 years, 4 months ago (2015-08-18 22:03:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 22:09:01 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 22:09:43 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ea51468614165ef8cdc3ec1317cb941e44335098
Cr-Commit-Position: refs/heads/master@{#344047}

Powered by Google App Engine
This is Rietveld 408576698