Initial commit of the blimp/ folder and target

blimp/client/android/blimp_view.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_ANDROID_BLIMP_VIEW_H_
+#define BLIMP_CLIENT_ANDROID_BLIMP_VIEW_H_
+
+#include "base/android/jni_android.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+
+namespace gfx {
+class Size;
+}
+
+namespace blimp {
+
+class BlimpCompositorAndroid;
+
+// The native component of org.chromium.blimp.BlimpView.  This builds and
+// maintains a BlimpCompositorAndroid and handles notifying the compositor of
+// SurfaceView surface changes (size, creation, destruction, etc.).
+class BlimpView {
+ public:
+  static bool RegisterJni(JNIEnv* env);
+
+  BlimpView(JNIEnv* env,
+            jobject jobj,
+            const gfx::Size& physical_size,
+            const gfx::Size& display_size,
+            float dp_to_pixel);

[Wez, 2015/08/27 02:01:50]

nit: Document parameters.

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

Done.

+
+  // JNI Methods

[Wez, 2015/08/27 02:01:51]

nit: Suggest "Handlers for calls from Java." or similar, so it's clear that
these are Java->C++, not wrappers for C++->Java?

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

Updated to "Methods called from Java via JNI"

Generally C++ -> Java isn't exposed in any non-auto generated header.

[Wez, 2015/09/03 00:49:26]

Acknowledged.

+  void Destroy(JNIEnv* env, jobject jobj);

[Wez, 2015/08/27 02:01:50]

nit: OnDestroy?

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

I don't know if I agree.  This actually destroys the object because it's owned
by the Java component.  Destroy() feels like a call that actually does the
destruction.  OnDestroy() feels like a notification call.

[Wez, 2015/09/03 00:49:26]

SGTM

+  void SetNeedsComposite(JNIEnv* env, jobject jobj);
+  void SurfaceChanged(JNIEnv* env,

[Wez, 2015/08/27 02:01:51]

nit: OnSurfaceChanged, and similarly below?

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

Done.

+                      jobject jobj,
+                      jint format,
+                      jint width,
+                      jint height,
+                      jobject jsurface);
+  void SurfaceCreated(JNIEnv* env, jobject jobj);
+  void SurfaceDestroyed(JNIEnv* env, jobject jobj);
+  void SetVisibility(JNIEnv* env, jobject jobj, jboolean visible);
+
+ private:
+  virtual ~BlimpView();
+
+  base::android::ScopedJavaGlobalRef<jobject> java_obj_;

[Wez, 2015/08/27 02:01:50]

nit: Document this and |current_surface_format_|

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

Done.  You'll see java_obj_ everywhere there's a native <-> JNI class coupling.

[Wez, 2015/09/03 00:49:26]

Acknowledged.

+
+  scoped_ptr<BlimpCompositorAndroid> compositor_;
+  int current_surface_format_;

[Wez, 2015/08/27 02:01:50]

nit: You can initialize this in-line.

[David Trainor- moved to gerrit, 2015/08/28 01:23:45]

Oh I forgot about that!  Is it required?  IIRC the chromium-dev@ thread seemed
to leave it open-ended. I'd rather initialize all variables together unless the
new standard is to in-line initializations.

[Wez, 2015/09/03 00:49:26]

No, it's not required; it's mainly helpful if you would otherwise be able to get
away w/out any member initialization in the ctor, or if you have several ctors
and lots of members - although ctor delegation also helps there.

[David Trainor- moved to gerrit, 2015/09/03 06:33:21]

Good point.  I'll move towards this in the future if I can get rid of all member
initialization in the constructors :).

+
+  DISALLOW_COPY_AND_ASSIGN(BlimpView);
+};
+
+}  // namespace blimp
+
+#endif  // BLIMP_CLIENT_ANDROID_BLIMP_VIEW_H_