blimp/client/android/blimp_jni_registrar.h - Issue 1295243003: Initial commit of the blimp/ folder and target

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/android/blimp_jni_registrar.h

Issue 1295243003: Initial commit of the blimp/ folder and target (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BLIMP_CLIENT_ANDROID_BLIMP_JNI_REGISTRAR_H_

	6 #define BLIMP_CLIENT_ANDROID_BLIMP_JNI_REGISTRAR_H_

	7

	8 #include <jni.h>

	9

	10 namespace blimp {

	11

	12 bool RegisterBlimpJni(JNIEnv* env);
	Wez 2015/08/27 02:01:50 nit: Comment to explain what this does, who owns \| nit: Comment to explain what this does, who owns \|env\| & why it's req'd, what the return value means? e.g. does a return value of false mean All Is Lost...? David Trainor- moved to gerrit 2015/09/03 06:33:21 I'll try to read up on it and add a comment (the s Show quoted text On 2015/08/27 02:01:50, Wez wrote: > nit: Comment to explain what this does, who owns \|env\| & why it's req'd, what > the return value means? e.g. does a return value of false mean All Is Lost...? I'll try to read up on it and add a comment (the same general structure used in about 50 places for all of Chromium's native/Java bridge setups. I've always known I have to do it, but I don't know the inner workings of all of these components :/).
	13

	14 } // namespace blimp

	15

	16 #endif // BLIMP_CLIENT_ANDROID_BLIMP_JNI_REGISTRAR_H_

OLD	NEW