Issue 1295213002: Revert of Fix a few bugs in the google3 sync scripts. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(250)

My Issues | Starred Open | Closed | All

Issue 1295213002: Revert of Fix a few bugs in the google3 sync scripts. (Closed)

Created:
5 years, 4 months ago by dogben

Modified:
5 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/1291343006/ ) Reason for revert: MacMini buildbots were unable to apply the patch. fatal: Could not parse object '18af0a0080cc2b2b3464292d35a0886cdade551f'. http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580 http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474 http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566 http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480 http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456 http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364 Original issue's description: > Fix a few bugs in the google3 sync scripts. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f TBR=mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e349d6b92574c1b0acdb4ba1ed8ff905ea830131

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	tools/git_clone_to_google3.sh	View		3 chunks	+3 lines, -9 lines	0 comments	Download
	M	tools/sync_google3.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dogben

Created Revert of Fix a few bugs in the google3 sync scripts.

5 years, 4 months ago (2015-08-17 21:43:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295213002/1

5 years, 4 months ago (2015-08-17 21:43:51 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e349d6b92574c1b0acdb4ba1ed8ff905ea830131

5 years, 4 months ago (2015-08-17 21:44:03 UTC) #3

dogben

5 years, 4 months ago (2015-08-18 13:24:56 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1284093003/ by benjaminwagner@google.com.

The reason for reverting is: Retry..

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698