Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1295203002: cc: Make FixedPositionWithInterveningRenderSurface use property trees (Closed)

Created:
5 years, 4 months ago by enne (OOO)
Modified:
5 years, 4 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make FixedPositionWithInterveningRenderSurface use property trees Previously it was looking at draw_transform which doesn't get filled in on the main thread by property trees. Once main thread CDP is removed, Layer::draw_transform can do this work, and this can be reverted. R=weiliangc@chromium.org BUG=502041 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f6903539e8e879a3eef8da50661f7de12af36e65 Cr-Commit-Position: refs/heads/master@{#343802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
enne (OOO)
5 years, 4 months ago (2015-08-17 21:00:01 UTC) #1
weiliangc
LGTM
5 years, 4 months ago (2015-08-17 21:04:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295203002/1
5 years, 4 months ago (2015-08-17 21:04:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/75555)
5 years, 4 months ago (2015-08-17 23:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295203002/1
5 years, 4 months ago (2015-08-18 00:31:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 05:10:21 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:11:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6903539e8e879a3eef8da50661f7de12af36e65
Cr-Commit-Position: refs/heads/master@{#343802}

Powered by Google App Engine
This is Rietveld 408576698