Delay bookmarks load while the profile is loading.

chrome/browser/profiles/startup_task_runner_service.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profiles/startup_task_runner_service.h"
+
+#include "base/logging.h"
+#include "chrome/browser/profiles/profile.h"
+
+StartupTaskRunnerService::StartupTaskRunnerService(Profile* profile)
+    : profile_(profile) {
+}
+
+StartupTaskRunnerService::~StartupTaskRunnerService() {
+}
+
+scoped_refptr<base::DeferredSequencedTaskRunner>
+    StartupTaskRunnerService::GetBookmarkTaskRunner() {
+  DCHECK(CalledOnValidThread());
+  if (!bookmark_task_runner_) {
+    bookmark_task_runner_ =
+        new base::DeferredSequencedTaskRunner(profile_->GetIOTaskRunner());

[erikwright (departed), 2013/04/15 17:56:25]

Why not eliminate a dependency on profile.h by taking a STR in the constructor
and storing that instead of Profile*? It's reasonable for the factory to do the
accessing for you.

[msarda, 2013/04/17 09:53:55]

I don't see the fact that this service holds profile as an inconvenient - it is
a profile service at the end. We could image that in the future other task
runners might be added and they may need the profile.

Thus I'll keep it as is for now as mirandac (owner for chrome/browser/profiles)
already l g t m -ed this CL.

[erikwright (departed), 2013/04/17 14:41:19]

Across the project we are actively trying to reduce coupling to profiles, not
increase it.

Notice that, if you remove the dependency on Profile, this class goes from very
high up the food-chain (depending on browser) to very low in the food chain
(depending on base). This is a very good thing for simplifying the browser
architecture.

If for some reason a future incarnation of this service requires more
parameters, let's address it then.

Miranda, please chime in if you object.

[Miranda Callahan, 2013/04/17 15:35:12]

I think Erik is right that this basic structure should be changed, and we should
move Profile out of the equation here. However, this CL has been through so
much, I think it's fine for Mihai to commit, and then perform this extraction in
a follow-up. (We just discussed on IRC, and he agreed to this).

On 2013/04/17 14:41:19, erikwright wrote:

+  }
+  return bookmark_task_runner_;
+}
+
+void StartupTaskRunnerService::StartDeferredTaskRunners() {
+  GetBookmarkTaskRunner()->Start();
+}