Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 12952005: Delay bookmarks load while the profile is loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add deferred_sequenced_task_runner_unittest Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Bookmarks is being made into a component (it will end up at 2 # Bookmarks is being made into a component (it will end up at
3 # //components/bookmarks and not depend on //chrome), so we have these basic 3 # //components/bookmarks and not depend on //chrome), so we have these basic
4 # rules followed by temporary exceptions. Please don't add to the list of 4 # rules followed by temporary exceptions. Please don't add to the list of
5 # exceptions! 5 # exceptions!
6 "-chrome/browser", 6 "-chrome/browser",
7 "+chrome/browser/api", 7 "+chrome/browser/api",
tfarina 2013/03/29 14:47:40 looks like you need to sync your checkout. I have
8 "+chrome/browser/bookmarks", 8 "+chrome/browser/bookmarks",
9 9
10 # TODO(kaiwang): Bring this list to zero. 10 # TODO(kaiwang): Bring this list to zero.
11 # Do not add to the list of temporarily-allowed dependencies below, 11 # Do not add to the list of temporarily-allowed dependencies below,
12 # and please do not introduce more #includes of these files. 12 # and please do not introduce more #includes of these files.
13 "!chrome/browser/favicon/favicon_service.h", 13 "!chrome/browser/favicon/favicon_service.h",
14 "!chrome/browser/favicon/favicon_service_factory.h", 14 "!chrome/browser/favicon/favicon_service_factory.h",
15 "!chrome/browser/history/history_notifications.h", 15 "!chrome/browser/history/history_notifications.h",
16 "!chrome/browser/history/history_service.h", 16 "!chrome/browser/history/history_service.h",
17 "!chrome/browser/history/history_service_factory.h", 17 "!chrome/browser/history/history_service_factory.h",
18 "!chrome/browser/history/history_types.h", 18 "!chrome/browser/history/history_types.h",
19 "!chrome/browser/history/query_parser.h", 19 "!chrome/browser/history/query_parser.h",
20 "!chrome/browser/history/snippet.h", 20 "!chrome/browser/history/snippet.h",
21 "!chrome/browser/history/url_database.h", 21 "!chrome/browser/history/url_database.h",
22 "!chrome/browser/profiles/profile.h", 22 "!chrome/browser/profiles/profile.h",
23 "!chrome/browser/profiles/profile_dependency_manager.h", 23 "!chrome/browser/profiles/profile_dependency_manager.h",
24 "!chrome/browser/profiles/profile_keyed_service.h", 24 "!chrome/browser/profiles/profile_keyed_service.h",
25 "!chrome/browser/profiles/profile_keyed_service_factory.h", 25 "!chrome/browser/profiles/profile_keyed_service_factory.h",
26 "!chrome/browser/profiles/startup_task_runner_service.h",
msarda 2013/03/29 14:40:03 This is bad (I saw the comments above and below).
tfarina 2013/03/29 14:47:40 The decision is from Scott, so I'll let him decide
27 "!chrome/browser/profiles/startup_task_runner_service_factory.h",
26 # Do not add to the list of temporarily-allowed dependencies above, 28 # Do not add to the list of temporarily-allowed dependencies above,
27 # and please do not introduce more #includes of these files. 29 # and please do not introduce more #includes of these files.
28 ] 30 ]
29 31
30 specific_include_rules = { 32 specific_include_rules = {
31 # TODO(kaiwang): Bring this list to zero. 33 # TODO(kaiwang): Bring this list to zero.
32 # Do not add to the list of temporarily-allowed dependencies below, 34 # Do not add to the list of temporarily-allowed dependencies below,
33 # and please do not introduce more #includes of these files. 35 # and please do not introduce more #includes of these files.
34 '.*_[a-z]*test\.cc': [ 36 '.*_[a-z]*test\.cc': [
35 "!chrome/browser/importer/firefox2_importer.h", 37 "!chrome/browser/importer/firefox2_importer.h",
36 ] 38 ]
37 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698