Issue 12952002: Make GDBJIT interface compile again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12952002: Make GDBJIT interface compile again. (Closed)

Created:
7 years, 9 months ago by haitao.feng

Modified:
7 years, 9 months ago

Reviewers:
rossberg, Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Make GDBJIT interface compile again. Committed: http://code.google.com/p/v8/source/detail?r=14002

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
	M	src/gdb-jit.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/gdb-jit.cc	View		13 chunks	+22 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Recent commits break gdbjit=on: 1) https://codereview.chromium.org/12210083 introduced class StringTable. 2) https://codereview.chromium.org/12223071 introduced class Name. For ...

7 years, 9 months ago (2013-03-20 11:01:12 UTC) #1

Michael Starzinger

7 years, 9 months ago (2013-03-20 11:29:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14002 (presubmit successful).

Expand Messages | Collapse Messages