Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1295163005: Update Crashpad to 1a770c8237733e2f68bd506a99d05d82fe25fc6b (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek, brettw
CC:
chromium-reviews, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 1a770c8237733e2f68bd506a99d05d82fe25fc6b 263582c2d067 Refactor multiprocess test code to allow multiple child processes to be launched a3e313ecd725 10.10 SDK compatibility for Mac OS X 10.6 03663076154a win: Provide strcasecmp() in <strings.h> in compat 43a71b9302bf Update mini_chromium to db01ece1d0dd cd1f8fa3d2f2 Tolerate weird cl_kernels modules on Mac OS X 10.11 5e8e72f91c73 Don’t use DYLD_INSERT_LIBRARIES with a system executable 29eeec3d56ad Remove unused #include following 03663076154a 124ace19bdce crashpad_database_util: Accept --new-report=- to read a new report from standard input 6083a2706d55 Recognize crashreporter_annotations_t version 5 found on OS X 10.11 402bb216fb2b Provide a properly-typed ExpectedSizeForVersion() for types that need it eb7ca8c37419 Fix a few pieces of documentation ad09fd1bc818 DCHECK_IS_ON needs () e74922936da1 Check the size of of the dyld_all_image_infos structure before using it 1a770c823773 Implement more of CrashpadClient on Windows This eliminates Crashpad's dependency on base::strcasecmp(), so that function can be removed. BUG=472900 Committed: https://crrev.com/918863e4305589e0165fbf23f284b8e05ee71e4d Cr-Commit-Position: refs/heads/master@{#343812}

Patch Set 1 #

Patch Set 2 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-17 22:28:51 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-08-17 22:30:07 UTC) #4
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-17 22:33:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295163005/20001
5 years, 4 months ago (2015-08-18 00:14:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99455)
5 years, 4 months ago (2015-08-18 02:59:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295163005/20001
5 years, 4 months ago (2015-08-18 03:09:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 05:16:55 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:17:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/918863e4305589e0165fbf23f284b8e05ee71e4d
Cr-Commit-Position: refs/heads/master@{#343812}

Powered by Google App Engine
This is Rietveld 408576698