Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1295093002: Do not use js builtins object when constructing an error. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not use js builtins object when constructing an error. R=cbruni@chromium.org Committed: https://crrev.com/d281688ae571bc2e5a302ee32a503be32c4ae720 Cr-Commit-Position: refs/heads/master@{#30189}

Patch Set 1 #

Patch Set 2 : fix failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -180 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 2 chunks +16 lines, -34 lines 0 comments Download
M src/factory.cc View 1 2 chunks +9 lines, -120 lines 0 comments Download
M src/messages.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/messages.cc View 1 1 chunk +18 lines, -12 lines 0 comments Download
M src/messages.js View 3 chunks +1 line, -9 lines 0 comments Download
M src/pending-compilation-error-handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/error-constructors.js View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
5 years, 4 months ago (2015-08-17 08:08:18 UTC) #1
Yang
This follows the pattern of putting the function into a native context slot instead of ...
5 years, 4 months ago (2015-08-17 08:09:10 UTC) #2
Camillo Bruni
lgtm
5 years, 4 months ago (2015-08-17 09:33:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295093002/20001
5 years, 4 months ago (2015-08-17 09:37:04 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-17 09:37:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295093002/20001
5 years, 4 months ago (2015-08-17 09:56:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295093002/20001
5 years, 4 months ago (2015-08-17 11:00:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-17 11:02:36 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 11:02:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d281688ae571bc2e5a302ee32a503be32c4ae720
Cr-Commit-Position: refs/heads/master@{#30189}

Powered by Google App Engine
This is Rietveld 408576698