Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1295083004: Support FrozenArray in idl_parser.py (Closed)

Created:
5 years, 4 months ago by bashi
Modified:
5 years, 4 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support FrozenArray in idl_parser.py Spec: http://heycam.github.io/webidl/#idl-frozen-array Almost the same as sequence<T>. BUG=515920 Committed: https://crrev.com/cb5c1661b199801a9763919353702c9ea020be01 Cr-Commit-Position: refs/heads/master@{#344129}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M tools/idl_parser/idl_lexer.py View 1 chunk +1 line, -0 lines 2 comments Download
M tools/idl_parser/idl_parser.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bashi
PTAL? The WebIDL spec has introduced FrozenArray and removed Arrays. I don't think we want ...
5 years, 4 months ago (2015-08-19 01:05:15 UTC) #2
haraken
LGTM https://codereview.chromium.org/1295083004/diff/1/tools/idl_parser/idl_lexer.py File tools/idl_parser/idl_lexer.py (right): https://codereview.chromium.org/1295083004/diff/1/tools/idl_parser/idl_lexer.py#newcode83 tools/idl_parser/idl_lexer.py:83: 'FrozenArray' : 'FROZENARRAY', Nit: This dictionary should be ...
5 years, 4 months ago (2015-08-19 01:14:18 UTC) #3
bashi
Thanks! https://codereview.chromium.org/1295083004/diff/1/tools/idl_parser/idl_lexer.py File tools/idl_parser/idl_lexer.py (right): https://codereview.chromium.org/1295083004/diff/1/tools/idl_parser/idl_lexer.py#newcode83 tools/idl_parser/idl_lexer.py:83: 'FrozenArray' : 'FROZENARRAY', On 2015/08/19 01:14:18, haraken wrote: ...
5 years, 4 months ago (2015-08-19 01:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295083004/1
5 years, 4 months ago (2015-08-19 01:19:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 02:11:34 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 02:12:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb5c1661b199801a9763919353702c9ea020be01
Cr-Commit-Position: refs/heads/master@{#344129}

Powered by Google App Engine
This is Rietveld 408576698