Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1295073002: Move serializer related files in core/editing/ related files into core/editing/serializers/ (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, pfeldman+blink_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, groby+blinkspell_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, tyoshino+watch_chromium.org, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move serializer related files in core/editing/ related files into core/editing/serializers/ This patch moves spell checker related files into "core/editing/serializers/" directory to reduce number of files immediately under "core/editing/" for ease of working these files as same as issue 448772, which moves iterator related files into "core/editing/iterators/". Moved files: - HTMLInterchange.{cpp,h} - MarkupAccumulator.{cpp,h} - MarkupFormatter.{cpp,h} - Serialization.{cpp,h} - StyledMarkupAccumulator.{cpp,h} - StyledMarkupSerializer.{cpp,h} - StyledMarkupSerializerTest.cpp - TextOffset.{cpp,h} BUG=509527 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200633

Patch Set 1 : 2015-08-17T11:14:04 #

Patch Set 2 : 2015-08-17T12:53:33 Rebase for core/editing/spellchecker #

Patch Set 3 : 2015-08-17T15:24:31 Rebase for Source/web/WebPageSerializerImpl.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3057 lines) Patch
M Source/core/clipboard/DataTransfer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 6 chunks +15 lines, -14 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/editing/HTMLInterchange.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/editing/HTMLInterchange.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/editing/MarkupAccumulator.h View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/core/editing/MarkupAccumulator.cpp View 1 chunk +0 lines, -198 lines 0 comments Download
D Source/core/editing/MarkupFormatter.h View 1 chunk +0 lines, -106 lines 0 comments Download
D Source/core/editing/MarkupFormatter.cpp View 1 chunk +0 lines, -469 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/editing/Serialization.h View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/editing/Serialization.cpp View 1 chunk +0 lines, -714 lines 0 comments Download
D Source/core/editing/StyledMarkupAccumulator.h View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/editing/StyledMarkupAccumulator.cpp View 1 chunk +0 lines, -228 lines 0 comments Download
D Source/core/editing/StyledMarkupSerializer.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/core/editing/StyledMarkupSerializer.cpp View 1 chunk +0 lines, -484 lines 0 comments Download
D Source/core/editing/StyledMarkupSerializerTest.cpp View 1 chunk +0 lines, -233 lines 0 comments Download
D Source/core/editing/TextOffset.h View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/core/editing/TextOffset.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
A + Source/core/editing/serializers/HTMLInterchange.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/serializers/HTMLInterchange.cpp View 2 chunks +26 lines, -25 lines 0 comments Download
A + Source/core/editing/serializers/MarkupAccumulator.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/serializers/MarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/MarkupFormatter.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/MarkupFormatter.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/Serialization.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/Serialization.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/editing/serializers/StyledMarkupAccumulator.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/serializers/StyledMarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/StyledMarkupSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/StyledMarkupSerializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/editing/serializers/StyledMarkupSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/serializers/TextOffset.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/serializers/TextOffset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-17 04:48:16 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-17 05:32:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295073002/20001
5 years, 4 months ago (2015-08-17 05:35:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/103595)
5 years, 4 months ago (2015-08-17 05:44:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295073002/40001
5 years, 4 months ago (2015-08-17 06:30:17 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 07:57:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200633

Powered by Google App Engine
This is Rietveld 408576698