Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1295043002: Revert of Add a library for running external commands, providing timeouts and test injection. (Closed)

Created:
5 years, 4 months ago by rmistry
Modified:
5 years, 4 months ago
Reviewers:
jcgregorio, dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Add a library for running external commands, providing timeouts and test injection. (patchset #2 id:40001 of https://codereview.chromium.org/1290913004/ ) Reason for revert: CT Chromium Perf tasks are failing with: E0815 11:07:22.649344 13091 exec.go:193] Command exited with invalid argument: python /b/skia-repo/go/src/go.skia.org/infra/ct/py/sync_skia_in_chrome.py --destination=/b/storage/chromium_builds/linux_base --fetch_target=chromium --chrome_revision=6ae54795f6d077e31f4fb42540ead46f4141f2bb --skia_revision=fb28cd2b13d76c324570341e1155aaadc1b532b6 Original issue's description: > Add a library for running external commands, providing timeouts and test injection. > > BUG=skia:4106 > > Committed: https://skia.googlesource.com/buildbot/+/b65fde6749a3e060938cd280c7e281e29516edc1 TBR=jcgregorio@google.com,benjaminwagner@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4106 Committed: https://skia.googlesource.com/buildbot/+/ac6c1292955c888d35f6c01cf97d3b6ff4029424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -524 lines) Patch
M ct/go/adb/adb.go View 3 chunks +4 lines, -3 lines 0 comments Download
M ct/go/util/util.go View 2 chunks +53 lines, -12 lines 0 comments Download
D go/exec/exec.go View 1 chunk +0 lines, -234 lines 0 comments Download
D go/exec/exec_test.go View 1 chunk +0 lines, -272 lines 0 comments Download
M go/util/command.go View 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmistry
Created Revert of Add a library for running external commands, providing timeouts and test injection.
5 years, 4 months ago (2015-08-15 18:08:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295043002/1
5 years, 4 months ago (2015-08-15 18:08:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/buildbot/+/ac6c1292955c888d35f6c01cf97d3b6ff4029424
5 years, 4 months ago (2015-08-15 18:08:26 UTC) #3
dogben
On 2015/08/15 18:08:07, rmistry wrote: > Created Revert of Add a library for running external ...
5 years, 4 months ago (2015-08-17 21:35:48 UTC) #4
rmistry
On 2015/08/17 21:35:48, Ben Wagner wrote: > On 2015/08/15 18:08:07, rmistry wrote: > > Created ...
5 years, 4 months ago (2015-08-17 23:29:45 UTC) #5
dogben
5 years, 4 months ago (2015-08-18 20:05:26 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1302513006/ by benjaminwagner@google.com.

The reason for reverting is: Creating new issue to reland..

Powered by Google App Engine
This is Rietveld 408576698