Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1295023004: gn/clang: Only pass -Wno-reserved-user-defined-literal on Linux and Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 7a00b9384cf9ad756b5e3bcb9a55cfdfbb6b5898..b305d86b9c89cee7aad147e65b8ffc314b29203a 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -959,11 +959,15 @@ if (is_clang) {
# which we no longer use. Check if it makes sense to remove
# this as well. http://crbug.com/316352
"-Wno-unneeded-internal-declaration",
-
- # TODO(thakis): Remove, http://crbug.com/263960
- "-Wno-reserved-user-defined-literal",
]
+ if (is_posix && !is_mac && !is_ios) {
+ default_warning_flags += [
+ # TODO(thakis): Remove, http://crbug.com/263960
+ "-Wno-reserved-user-defined-literal",
+ ]
+ }
+
# NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
# always have different versions. Certain flags may not be recognized by
# one version or the other.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698