Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1295023004: gn/clang: Only pass -Wno-reserved-user-defined-literal on Linux and Android. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/clang: Only pass -Wno-reserved-user-defined-literal on Linux and Android. This matches gyp. The flag is not needed on Windows and Mac. (It probably isn't needed on Android either.) BUG=263960 Committed: https://crrev.com/64dff6deeae1788cdc60b5c02e82c527385dfe7a Cr-Commit-Position: refs/heads/master@{#344275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 4 months ago (2015-08-17 22:52:46 UTC) #2
brettw
LGTM. Sorry I didn't see this earlier.
5 years, 4 months ago (2015-08-19 17:05:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295023004/1
5 years, 4 months ago (2015-08-19 17:08:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 18:19:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 18:20:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64dff6deeae1788cdc60b5c02e82c527385dfe7a
Cr-Commit-Position: refs/heads/master@{#344275}

Powered by Google App Engine
This is Rietveld 408576698