Issue 12950004: Isolatify CPU profiler public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12950004: Isolatify CPU profiler public API (Closed)

Created:
7 years, 9 months ago by yurys

Modified:
7 years, 9 months ago

Reviewers:
Sven Panne, alph, loislo

CC:
chromium-reviews, pfeldman

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -63 lines)			Patch
M	include/v8.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	include/v8-profiler.h	View	1 2	4 chunks	+33 lines, -8 lines	0 comments	Download
M	src/api.cc	View	1 2	7 chunks	+50 lines, -0 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View		1 chunk	+53 lines, -51 lines	0 comments	Download
M	test/cctest/test-profile-generator.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

yurys

This change addresses https://codereview.chromium.org/12706020/#msg

7 years, 9 months ago (2013-03-20 11:27:33 UTC) #1

loislo

On 2013/03/20 11:27:33, Yury Semikhatsky wrote: > This change addresses https://codereview.chromium.org/12706020/#msg lgtm

7 years, 9 months ago (2013-03-20 11:56:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r14006.