Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: content/browser/devtools/devtools_remote_agent_connector_impl.h

Issue 12950002: Introduce DevToolsExternalAgentProxy interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_remote_agent_connector_impl.h
diff --git a/content/browser/devtools/devtools_remote_agent_connector_impl.h b/content/browser/devtools/devtools_remote_agent_connector_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..7eb67529510eb5544b8b6a9a00ec2f872c71b2c9
--- /dev/null
+++ b/content/browser/devtools/devtools_remote_agent_connector_impl.h
@@ -0,0 +1,29 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_REMOTE_AGENT_CONNECTOR_IMPL_H_
+#define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_REMOTE_AGENT_CONNECTOR_IMPL_H_
+
+#include "content/browser/devtools/devtools_agent_host_impl.h"
+#include "content/public/browser/devtools_remote_agent_connector.h"
+
+namespace content {
+
+class ForwardingDevToolsAgentHost;
+
+class CONTENT_EXPORT DevToolsRemoteAgentConnectorImpl
+ : public DevToolsRemoteAgentConnector {
+ public:
+ // RemoteDevToolsAgentConnector implementation.
+ virtual DevToolsAgentHost* GetAgentHost() OVERRIDE;
+ virtual void ConnectionClosed() OVERRIDE;
+ private:
+ friend class DevToolsRemoteAgentConnector;
pfeldman 2013/03/21 06:24:32 Your base is your friend? Why?
Vladislav Kaznacheev 2013/03/21 06:55:53 Because it is being instantiated by a static metho
+ ForwardingDevToolsAgentHost* agent_host_;
pfeldman 2013/03/21 06:24:32 This should be scoped_refptr
Vladislav Kaznacheev 2013/03/21 06:55:53 Done. Also made the base refcounted.
+ DevToolsRemoteAgentConnectorImpl(Delegate* delegate);
pfeldman 2013/03/21 06:24:32 DISALLOW_COPY_AND_ASSIGN
Vladislav Kaznacheev 2013/03/21 06:55:53 Done.
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_REMOTE_AGENT_CONNECTOR_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698