Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 12950002: Introduce DevToolsExternalAgentProxy interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index 6e1f4812a71393b62af34d553596f44e37cb1d52..3fe694fce508db33c5bde40b6437110a0dc7643a 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -27,11 +27,14 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
virtual ~CloseListener() {}
};
- // Sends the message to the devtools agent hosted by this object.
- void Attach();
- void Reattach(const std::string& saved_agent_state);
- void Detach();
- virtual void DispatchOnInspectorBackend(const std::string& message);
+ // Sends the attach message to the devtools agent hosted by this object.
+ virtual void Attach() = 0;
+
+ // Sends the detach message to the devtools agent hosted by this object.
+ virtual void Detach() = 0;
+
+ // Dispatches a message to the devtools agent hosted by this object.
+ virtual void DispatchOnInspectorBackend(const std::string& message) = 0;
void set_close_listener(CloseListener* listener) {
close_listener_ = listener;
@@ -48,10 +51,6 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
DevToolsAgentHostImpl();
virtual ~DevToolsAgentHostImpl();
- virtual void SendMessageToAgent(IPC::Message* msg) = 0;
- virtual void NotifyClientAttaching() = 0;
- virtual void NotifyClientDetaching() = 0;
-
void NotifyCloseListener();
private:

Powered by Google App Engine
This is Rietveld 408576698