Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio…

Source/platform/weborigin/SecurityOriginTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "platform/weborigin/SecurityOrigin.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
+#include "platform/blob/BlobURL.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityPolicy.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/WTFString.h"
 #include <gtest/gtest.h>
 
 namespace blink {
 
 const int MaxAllowedPort = 65535;
 
@@ skipping 333 matching lines @@
         {"file", "example.com", 0, "file://"},
     };
 
     for (const auto& test : cases) {
         RefPtr<SecurityOrigin> origin = SecurityOrigin::create(test.scheme, test.host, test.port);
         EXPECT_EQ(test.origin, origin->toString()) << test.origin;
     }
 
 }
 
+TEST_F(SecurityOriginTest, UniquenessPropagatesToBlobUrls)
+{
+    const char* uniqueOriginUrls[] = {
+        "",
+        "data:text/plain,hello_world",

[palmer, 2015/08/18 00:09:17]

What should happen for file: URLs? And filesystem:, and others?

[michaeln, 2015/08/18 20:22:16]

i've added some more cases, if you'd like to see other cases comment with the {
url, expectedBool, expectedString } lines and i'll plug them in

+    };
+
+    for (const char* url : uniqueOriginUrls) {
+        RefPtr<SecurityOrigin> origin = SecurityOrigin::create(KURL(ParsedURLString, url));
+        EXPECT_TRUE(origin->isUnique());
+        EXPECT_TRUE(SecurityOrigin::create(BlobURL::createPublicURL(origin.get()))->isUnique());
+    }
+}
+
 } // namespace blink