Add a triggered profile reset mechanism.

chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profile_resetter/triggered_profile_resetter.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/test/test_reg_util_win.h"
+#include "base/win/registry.h"
+#include "chrome/browser/prefs/browser_prefs.h"

[engedy, 2015/09/21 12:56:10]

nit: If the default TestingProfile ctor can be used, this will be no longer
needed.

[robertshield, 2015/09/21 22:04:30]

Done.

+#include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_pref_service_syncable.h"

[engedy, 2015/09/21 12:56:10]

nit: If the default TestingProfile ctor can be used, this can be replaced by
just "base/prefs/pref_service.h".

[robertshield, 2015/09/21 22:04:30]

Done.

+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using base::win::RegKey;
+
+class TriggeredProfileResetterTest : public testing::Test {
+ protected:
+  void SetUp() {
+    override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
+
+    // Create the profile.
+    TestingProfile::Builder builder;

[engedy, 2015/09/21 12:56:10]

nit: I think the default TestingProfile constructor creates a TestingPrefService
already, and I believe only the non-default constructors are being deprecated,
so the default one should be fine to use. So we could get rid of the boilerplate
here.

[robertshield, 2015/09/21 22:04:30]

Done.

+    TestingPrefServiceSyncable* pref_service = new TestingPrefServiceSyncable();
+    chrome::RegisterUserProfilePrefs(pref_service->registry());
+    builder.SetPrefService(make_scoped_ptr<PrefServiceSyncable>(pref_service));
+    profile_ = builder.Build();
+  }
+
+  content::TestBrowserThreadBundle thread_bundle_;
+  scoped_ptr<TestingProfile> profile_;
+
+ private:
+  registry_util::RegistryOverrideManager override_manager_;
+};
+
+TEST_F(TriggeredProfileResetterTest, HasResetTriggerAndClear) {
+  RegKey trigger_key(HKEY_CURRENT_USER, kTriggeredResetRegistryPath,

[engedy, 2015/09/21 12:56:10]

optional nit: I'd personally introduce a helper method to write a FILETIME and
tool name into the registry, so as to avoid these long and somewhat ugly
function calls. But I also see the value in having it explicitly spelled out in
each case, so I'd leave it up to you.

[robertshield, 2015/09/21 22:04:30]

Done.

+                     KEY_ALL_ACCESS);
+  ASSERT_TRUE(trigger_key.Valid());
+
+  FILETIME ft;
+  ::GetSystemTimeAsFileTime(&ft);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetTimestamp, &ft, sizeof(ft),
+                                     REG_QWORD) == ERROR_SUCCESS);
+
+  TriggeredProfileResetter triggered_profile_resetter(profile_.get());
+  triggered_profile_resetter.Activate();
+  EXPECT_TRUE(triggered_profile_resetter.HasResetTrigger());
+  triggered_profile_resetter.ClearResetTrigger();
+  EXPECT_FALSE(triggered_profile_resetter.HasResetTrigger());
+}
+
+TEST_F(TriggeredProfileResetterTest, HasDuplicateResetTrigger) {
+  RegKey trigger_key(HKEY_CURRENT_USER, kTriggeredResetRegistryPath,
+                     KEY_ALL_ACCESS);
+  ASSERT_TRUE(trigger_key.Valid());
+
+  FILETIME ft;
+  ::GetSystemTimeAsFileTime(&ft);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetTimestamp, &ft, sizeof(ft),
+                                     REG_QWORD) == ERROR_SUCCESS);
+  profile_->GetPrefs()->SetInt64(prefs::kLastProfileResetTimestamp,
+                                 bit_cast<int64, FILETIME>(ft));

[engedy, 2015/09/21 12:56:10]

Please use int64_t and include <stdint.h>. (int64 is deprecated.)

[robertshield, 2015/09/21 22:04:30]

Done.

+
+  TriggeredProfileResetter triggered_profile_resetter(profile_.get());
+  triggered_profile_resetter.Activate();
+  EXPECT_FALSE(triggered_profile_resetter.HasResetTrigger());
+}
+
+TEST_F(TriggeredProfileResetterTest, HasToolName) {
+  const wchar_t kToolName[] = L"ToolyMcTool";
+  RegKey trigger_key(HKEY_CURRENT_USER, kTriggeredResetRegistryPath,
+                     KEY_ALL_ACCESS);
+  ASSERT_TRUE(trigger_key.Valid());
+  FILETIME ft;
+  ::GetSystemTimeAsFileTime(&ft);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetTimestamp, &ft, sizeof(ft),
+                                     REG_QWORD) == ERROR_SUCCESS);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetToolName, kToolName) ==
+              ERROR_SUCCESS);
+
+  TriggeredProfileResetter triggered_profile_resetter(profile_.get());
+  triggered_profile_resetter.Activate();
+  EXPECT_TRUE(triggered_profile_resetter.HasResetTrigger());
+  EXPECT_STREQ(kToolName,
+               triggered_profile_resetter.GetResetToolName().c_str());
+}
+
+TEST_F(TriggeredProfileResetterTest, HasLongToolName) {
+  const wchar_t kLongToolName[] =
+      L"ToolMcToolToolMcToolToolMcToolToolMcToolToolMcToolToolMcToolToolMcTool"
+      L"ToolMcToolToolMcToolToolMcToolThisIsTheToolThatNeverEndsYesItGoesOnAnd"
+      L"OnMyFriend";
+  const wchar_t kExpectedToolName[] =
+      L"ToolMcToolToolMcToolToolMcToolToolMcToolToolMcToolToolMcToolToolMcTool"
+      L"ToolMcToolToolMcToolToolMcTool";
+  RegKey trigger_key(HKEY_CURRENT_USER, kTriggeredResetRegistryPath,
+                     KEY_ALL_ACCESS);
+  ASSERT_TRUE(trigger_key.Valid());
+  FILETIME ft;
+  ::GetSystemTimeAsFileTime(&ft);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetTimestamp, &ft, sizeof(ft),
+                                     REG_QWORD) == ERROR_SUCCESS);
+  ASSERT_TRUE(trigger_key.WriteValue(kTriggeredResetToolName, kLongToolName) ==
+              ERROR_SUCCESS);
+
+  TriggeredProfileResetter triggered_profile_resetter(profile_.get());
+  triggered_profile_resetter.Activate();
+  EXPECT_TRUE(triggered_profile_resetter.HasResetTrigger());
+  EXPECT_STREQ(kExpectedToolName,
+               triggered_profile_resetter.GetResetToolName().c_str());
+}