Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1294913009: Durable Storage: Add "deny" test (Closed)

Created:
5 years, 4 months ago by dgrogan
Modified:
5 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Durable Storage: Refactor browser test and test the basic "deny" flow. BUG=482814 Committed: https://crrev.com/4f90c20c1aed6be1e6041d168f6678752757dc27 Cr-Commit-Position: refs/heads/master@{#344397}

Patch Set 1 #

Total comments: 1

Patch Set 2 : change permission to is_persistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -54 lines) Patch
M chrome/browser/storage/durable_storage_browsertest.cc View 1 chunk +38 lines, -34 lines 0 comments Download
A + chrome/test/data/durable/durability-permissions.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
D chrome/test/data/durable/durability-window1.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/durable/durability-window2.html View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgrogan
Josh, could you review this?
5 years, 4 months ago (2015-08-19 20:48:15 UTC) #2
jsbell
lgtm Suggestions for additional cases: ACCEPT w/o the extra tab (i.e. mirror image of the ...
5 years, 4 months ago (2015-08-19 21:20:05 UTC) #3
jsbell
https://codereview.chromium.org/1294913009/diff/1/chrome/test/data/durable/durability-permissions.html File chrome/test/data/durable/durability-permissions.html (right): https://codereview.chromium.org/1294913009/diff/1/chrome/test/data/durable/durability-permissions.html#newcode11 chrome/test/data/durable/durability-permissions.html:11: navigator.storage.requestPersistent().then(function(permission) { nit: I guess this should be 'persistent' ...
5 years, 4 months ago (2015-08-19 21:21:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294913009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294913009/20001
5 years, 4 months ago (2015-08-20 00:03:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 01:25:32 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 01:25:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f90c20c1aed6be1e6041d168f6678752757dc27
Cr-Commit-Position: refs/heads/master@{#344397}

Powered by Google App Engine
This is Rietveld 408576698